Fix update-wikidata not being interruptable #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems which made it extremely annoying to terminate
update-wikidatarelated to the retry logic:retry_with_backoffdid not respectctrl_c_pressedand continued to retry although a termination was requestedKeyboardInterruptis only raised aftertime.sleepinretry_with_backoff, which can take substantial timeMoved
retry_with_backoffinto the class and respectctrl_c_pressed. UseThreading.Eventfor interruptible waiting. This also made the waiting in another place nicer.